Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Sample updates 7.1 #4268

Merged

Conversation

michael-hawker
Copy link
Member

Fixes #4258

Small adjustments made when getting 7.1 sample app ready.

PR Type

What kind of change does this PR introduce?

  • Sample app changes

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Sep 22, 2021

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi and Rosuavio September 22, 2021 22:35
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Sep 22, 2021
@michael-hawker michael-hawker changed the title Sample updates 7dot1 Small Sample updates 7.1 Sep 22, 2021
@michael-hawker michael-hawker merged commit ad58a3e into CommunityToolkit:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior sample app 🖼 sample bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListDetailsView runtime error in Store App when spawned from VS Debug hyperlink
2 participants