Creating Microsoft.Toolkit.Uwp.UI.Behaviors
#3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes ScrollHeader from the Controls Package Updates Sample pages to use Behaviors instead from new Behaviors package TODO/Broken: - Animation Behaviors Currently don't have a home (still in folder structure of Animations, most likely removed for new approach using Behaviors directly w/ new Animation System) - General Animation extensions removed (to be replaced with a new coordinated system) - Blur/Saturation Effect extensions don't have a home (to move to Media package?) - Sample App - Graph Control Samples (needs to be rebuilt with new Behaviors package) - ViewportBehavior Example (was using Blur Extension) - Re-apply Blur effect to the backgrounds in Shell.xaml as was using Behavior
ghost
added
the
|
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
Rosuavio
approved these changes
Dec 17, 2020
azchohfi
requested changes
Dec 18, 2020
Also refactored list to make it easier to read.
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3594
Refactor to help with #3594, cleans up dependencies for the controls/animations packages based on the behaviors dependencies. Few open items left though to discuss... We may want to make a new dev branch for a bit?
Removes
ScrollHeaderfrom the Controls PackageUpdates Sample pages to use Behaviors instead from new Behaviors package
TODO/Broken:
See #3594 (comment)
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ScrollHeaderis a light-weight wrapper around behaviors that was pulling in the animation and behaviors package.What is the new behavior?
Behaviors for
ListViewBaseheader helpers are in a separate behavior package (along with other behaviors now centralized).PR Checklist
Please check if your PR fulfills the following requirements: