-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating Microsoft.Toolkit.Uwp.UI.Behaviors
#3634
Creating Microsoft.Toolkit.Uwp.UI.Behaviors
#3634
Conversation
Removes ScrollHeader from the Controls Package Updates Sample pages to use Behaviors instead from new Behaviors package TODO/Broken: - Animation Behaviors Currently don't have a home (still in folder structure of Animations, most likely removed for new approach using Behaviors directly w/ new Animation System) - General Animation extensions removed (to be replaced with a new coordinated system) - Blur/Saturation Effect extensions don't have a home (to move to Media package?) - Sample App - Graph Control Samples (needs to be rebuilt with new Behaviors package) - ViewportBehavior Example (was using Blur Extension) - Re-apply Blur effect to the backgrounds in Shell.xaml as was using Behavior
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to remove ScroolHeader
from csproj. Microsoft.Toolkit.Uwp.UI.Controls/Microsoft.Toolkit.Uwp.UI.Controls.csproj#L34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing missing is the Smoke tests addition for the new behaviors package.
Also refactored list to make it easier to read.
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Related #3594
Refactor to help with #3594, cleans up dependencies for the controls/animations packages based on the behaviors dependencies. Few open items left though to discuss... We may want to make a new dev branch for a bit?
Removes
ScrollHeader
from the Controls PackageUpdates Sample pages to use Behaviors instead from new Behaviors package
TODO/Broken:
See #3594 (comment)
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ScrollHeader
is a light-weight wrapper around behaviors that was pulling in the animation and behaviors package.What is the new behavior?
Behaviors for
ListViewBase
header helpers are in a separate behavior package (along with other behaviors now centralized).PR Checklist
Please check if your PR fulfills the following requirements: