Fixes AlternatingRowForeground not being applied #4162
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AlternatingRowForeground not being applied when in Light theme.
Dark theme is OK.
Fixes #4140
Fixes AlternatingRowForeground not being applied when in Light theme.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The AlternatingRowForeground is not applied when in Light theme because the default value for the dependency property DataGridRow.Foreground is #FFFFFFFF but the foreground brush itself under Light Theme is not. That causes the LOC # 1129 (see below) to always evaluate to false under Light Theme, which in turn leads to the AlternatingRowForeground brush to be ignored every time.
[1129] if (this.Foreground.Equals(defaultForeground))
What is the new behavior?
This commit removes LOC # 1129 for causing the undesirable behavior. It also simplifies the resulting code.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Tested in Windows 21H1 only.Tested in Windows 21H1 only.
Edit no. 1: Fix the number of the issue that this PR aims to solve.