-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RichSuggestBox #4203
Refactor RichSuggestBox #4203
Conversation
Thanks huynhsontung for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@azchohfi thought we removed all the test certificates?
|
Opened #4204 to fix |
@huynhsontung just to triple-check, this is just pure shuffling, no changes to code, eh? If you update/merge main/rebase it should build again fine. |
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@michael-hawker There are some refactoring code changes in 0011a48 but it should behave the same. |
0011a48
to
ede46a3
Compare
Oops the rebase removed the auto merge label. @michael-hawker can you take a look again? |
Refactor
RichSuggestBox
for smaller and more maintainable code files.PR Type
What kind of change does this PR introduce?
What is the current behavior?
RichSuggestBox
has one bigRichSuggestBox.cs
file that has around ~1k lines of code.What is the new behavior?
Smaller and more maintainable code files for
RichSuggestBox
.PR Checklist
Please check if your PR fulfills the following requirements:
Other information