Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RichSuggestBox #4203

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

huynhsontung
Copy link
Contributor

@huynhsontung huynhsontung commented Aug 30, 2021

Refactor RichSuggestBox for smaller and more maintainable code files.

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

RichSuggestBox has one big RichSuggestBox.cs file that has around ~1k lines of code.

What is the new behavior?

Smaller and more maintainable code files for RichSuggestBox.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Aug 30, 2021

Thanks huynhsontung for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Rosuavio August 30, 2021 07:32
@michael-hawker
Copy link
Member

@azchohfi thought we removed all the test certificates?

"D:\a\1\s\Windows Community Toolkit.sln" (Build target) (1) ->
       "D:\a\1\s\UITests\UITests.App\UITests.App.csproj" (default target) (31) ->
       (_GenerateCurrentProjectAppxManifest target) -> 
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VisualStudio\v16.0\AppxPackage\Microsoft.AppXPackage.Targets(2717,5): warning APPX0108: The certificate specified has expired. For more information about renewing certificates, see http://go.microsoft.com/fwlink/?LinkID=241478. [D:\a\1\s\UITests\UITests.App\UITests.App.csproj]


       "D:\a\1\s\Windows Community Toolkit.sln" (Build target) (1) ->
       "D:\a\1\s\UITests\UITests.App\UITests.App.csproj" (default target) (31) ->
       (BuildNativePackage target) -> 
         C:\Program Files (x86)\Microsoft SDKs\UWPNuGetPackages\microsoft.net.native.compiler\2.2.10-rel-29722-00\tools\Microsoft.NetNative.targets(805,5): warning : ILTransform : warning ILT0005: Type 'Windows.UI.Xaml.Controls.Primitives.GeneratorPosition' from assembly 'Windows' was not included in compilation, but was referenced in the application. There may have been a missing assembly, or a dependency on a more recent Windows SDK release. [D:\a\1\s\UITests\UITests.App\UITests.App.csproj]


       "D:\a\1\s\Windows Community Toolkit.sln" (Build target) (1) ->
       "D:\a\1\s\UITests\UITests.App\UITests.App.csproj" (default target) (31) ->
       (_GenerateAppxPackageFile target) -> 
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VisualStudio\v16.0\AppxPackage\Microsoft.AppXPackage.Targets(3468,5): error APPX0108: The certificate specified has expired. For more information about renewing certificates, see http://go.microsoft.com/fwlink/?LinkID=241478. [D:\a\1\s\UITests\UITests.App\UITests.App.csproj]

@michael-hawker
Copy link
Member

Opened #4204 to fix

@michael-hawker
Copy link
Member

@huynhsontung just to triple-check, this is just pure shuffling, no changes to code, eh? If you update/merge main/rebase it should build again fine.

@ghost
Copy link

ghost commented Aug 30, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@huynhsontung
Copy link
Contributor Author

@michael-hawker There are some refactoring code changes in 0011a48 but it should behave the same.

@huynhsontung
Copy link
Contributor Author

Oops the rebase removed the auto merge label. @michael-hawker can you take a look again?

@ghost ghost removed the auto merge ⚡ label Sep 1, 2021
@michael-hawker michael-hawker merged commit 166e101 into CommunityToolkit:main Sep 2, 2021
@huynhsontung huynhsontung deleted the rsb-reorganize branch September 2, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants