-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ValidateAllProperties generation for generated properties #4221
Fixed ValidateAllProperties generation for generated properties #4221
Conversation
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@Sergio0694 looks like there's a conflict with your other PR now, want to resolve? |
223a38b
to
5c3a419
Compare
@michael-hawker Done 😄 |
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
4f3ad43
to
16d3e93
Compare
@Sergio0694 want to resolve conflicts? |
16d3e93
to
a3cce54
Compare
@michael-hawker Done! 🚀 |
@nickrandolph want to try out the preview package and let us know if this works for your scenario? |
Fixes #4184
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
The generated code for
ValidateAllProperties
is now correct.PR Checklist
Please check if your PR fulfills the following requirements: