Remove NotificationsVisualizerLibrary from sample app #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NotificationsVisualizerLibrary is being deprecated/no longer updated, and we really don't need this dependency. Replacing the previews with static images/GIFs so that there are still previews of the toasts/tiles without affecting sample functionality.
|
Thanks andrewleader for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
michael-hawker
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Code and images look good here on PR. @XAML-Knight want to give this a quick test too in the sample app?
michael-hawker
added
nuget 📦
optimization ☄
XAML-Knight
approved these changes
Sep 20, 2021
delete-merged-branch
bot
deleted the
aleader/remove-notificationsvisualizerlibrary
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NotificationsVisualizerLibrary is being deprecated/no longer updated, and we really don't need this dependency. Replacing the previews with static images/GIFs so that there are still previews of the toasts/tiles without affecting sample functionality.
Fixes
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We use the NotificationsVisualizerLibrary to display previews of the Live Tiles and toast notifications
What is the new behavior?
We use screenshots/GIFs to display previews of the Live Tiles and toast notifications
PR Checklist
Please check if your PR fulfills the following requirements:
Other information