Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crashes for shadow animations on unloaded items #4265

Merged

Conversation

Sergio0694
Copy link
Member

Fixes #4262

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Trying to animate shadows on unloaded events causes a crash.

What is the new behavior?

Animations on shadows that are no longer available are just skipped.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior animations 🏮 hotfix 🌶 labels Sep 21, 2021
@Sergio0694 Sergio0694 added this to the 7.1 milestone Sep 21, 2021
@ghost
Copy link

ghost commented Sep 21, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I thought I had tested this out the same as you had (when you sent screenshot over with you proposed fix), but your version definitely seems to resolve the issue.

Sorry for the trouble! Thanks for helping! 🦙❤

Copy link
Contributor

@Rosuavio Rosuavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works. Thanks @Sergio0694 !

@Rosuavio Rosuavio merged commit e09c779 into CommunityToolkit:main Sep 22, 2021
@Sergio0694 Sergio0694 deleted the bugfix/shadow-animation-crash branch September 22, 2021 22:38
@Sergio0694
Copy link
Member Author

No problem, happy to help any time! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animations 🏮 bug 🐛 An unexpected issue that highlights incorrect behavior hotfix 🌶 priority 🚩
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NRE in Animation API
3 participants