This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
Update packages #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to fix an error on iOS that said brindge should bot be synthesized since one is inherited from RCTEventEmitter.
…ntation constants
…ntation constants
-- Allows async get of orientation as our enum values
tdmaienschein
approved these changes
Feb 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
I made a few changes to this package. Mainly, I wanted to retrieve some values as your CCCameraOrientation values, since that's what the camera seems to mainly use.
getInitialOrientationInt()— Just likegetInitialOrientation, but returns a CCOrientation value instead of a string.getOrientationAsCCInt()— Just likegetOrientation()but returns a CCOrientation value instead of a device-specific int.@synthesize bridge = _bridge;from Orientation.m — I kept getting errors saying that you shouldn't synthesize the bridge when extending from RCTEventEmitter.@jasongaare we'll probably have to get Matt to look at some changes I made to Orientation.m. Not real strong on Objective-C. Let me know if you see any problems.