Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UBI image to keep pace with GLIBC version #373

Merged

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Jul 28, 2023

If you build the Compliance Operator from source and deploy it into a
cluster using make deploy-local, you'll see that the operator fails to
start because of a GLIBC error:

  compliance-operator: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by compliance-operator)
  compliance-operator: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by compliance-operator)

This is because the container image for golang:1.20 is referencing a
newer version fo GLIBC than what's available in the ubi8 minimal image.

This commit updates the ubi image so that we keep up with the GLIBC
version being referenced in newer golang versions.

Fixes #372

If you build the Compliance Operator from source and deploy it into a
cluster using `make deploy-local`, you'll see that the operator fails to
start because of a GLIBC error:

  compliance-operator: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by compliance-operator)
  compliance-operator: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by compliance-operator)

This is because the container image for golang:1.20 is referencing a
newer version fo GLIBC than what's available in the ubi8 minimal image.

This commit updates the ubi image so that we keep up with the GLIBC
version being referenced in newer golang versions.

Fixes openshift#372
@rhmdnd
Copy link
Author

rhmdnd commented Jul 28, 2023

Note that this patch won't be tested by CI since it's not updating the Dockerfile.ci or Dockerfile.ocp files.

Those files are being updated and tested separately in #259

@rhmdnd rhmdnd requested review from yuumasato and Vincent056 and removed request for jhrozek July 28, 2023 16:55
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit df82ddb into ComplianceAsCode:master Jul 28, 2023
5 checks passed
@yuumasato
Copy link
Member

@rhmdnd Thanks Lance, that solved the issue for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building operator images using build/Dockerfile fails with GLIBC issues
3 participants