-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMP-2176: Implement replaces
in bundle CSV
#475
Conversation
@rhmdnd: This pull request references CMP-2176 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.15." or "openshift-4.15.", but it targets "compliance-operator-1.4.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
config/manifests/bases/compliance-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
/hold for test |
I think the index image generation is more related with downstream(replace the placeholder version with the last released version) not upstream.
|
/unhold |
/label qe-approved |
@rhmdnd: This pull request references CMP-2176 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "compliance-operator-1.4.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The `replaces` attribute of an operator's CSV helps OLM build relationships between operators, making it easier for users to install older versions of an operator (or know which version supercedes the version they're using). This commit reintroduces the `replaces` attribute, since it was being deleted before as a side-effect of an operator-sdk update. It should be safe to include again.
@@ -1557,4 +1557,5 @@ spec: | |||
provider: | |||
name: Red Hat Inc. | |||
url: www.redhat.com | |||
version: 0.1.53 | |||
replaces: 1.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are fed into the bundle manifest as inputs, and here we're just updating them to be accurate with the most recent version of the compliance operator.
The next time we release, the replaces version should be 1.4.0
and the new version should be 1.4.1
.
/test e2e-aws-parallel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, sheriff-rh, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The
replaces
attribute of an operator's CSV helps OLM buildrelationships between operators, making it easier for users to install
older versions of an operator (or know which version supercedes the
version they're using).
This commit reintroduces the
replaces
attribute, since it was beingdeleted before as a side-effect of an operator-sdk update. It should be
safe to include again.