Fix platform role detection for Power and Z architecture #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently updated Compliance Operator support to only load ocp4 profiles when running on Power and Z systems, since those are currently the only profiles that are supported on those architectures. In the process, we added architecture detection so the operator knows if it's running OpenShift on amd64, ppc64le, or s390x. However, the operator will also create default scan settings based on the architecture and platform, which didn't take these into account. Since we were using new architecture/platform keys in the support mapping, they weren't being handled correctly when the operator created the default scan settings. This caused it to use a generic catch all to schedule scans on all available nodes. While this is fine for some platforms, like EKS, it doesn't work when nodes are in different node pools because they will constantly get different results and be INCONSISTENT.
rhmdnd
requested review from
yuumasato,
xiaojiey and
BhargaviGudi
and removed request for
jhrozek
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit fd670ef
into
ComplianceAsCode:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently updated Compliance Operator support to only load ocp4
profiles when running on Power and Z systems, since those are currently
the only profiles that are supported on those architectures.
In the process, we added architecture detection so the operator knows if
it's running OpenShift on amd64, ppc64le, or s390x. However, the
operator will also create default scan settings based on the
architecture and platform, which didn't take these into account.
Since we were using new architecture/platform keys in the support
mapping, they weren't being handled correctly when the operator created
the default scan settings. This caused it to use a generic catch all to
schedule scans on all available nodes. While this is fine for some
platforms, like EKS, it doesn't work when nodes are in different node
pools because they will constantly get different results and be
INCONSISTENT.