-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dconf profiles in Ubuntu CIS/STIG profiles #11874
Enable dconf profiles in Ubuntu CIS/STIG profiles #11874
Conversation
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
3f73342
to
4b3cdc4
Compare
4b3cdc4
to
1f004df
Compare
1f004df
to
0ae198a
Compare
/packit retest |
On Ubuntu, dconf profiles `gdm` and `user` are not explictly configured by default. When the profiles aren't explicitly defined and don't point to `gdm.d` and `local.d` dconf databases, respectively, the remediations from dconf rules will have no affect on gnome settings and the checks will give false positives. The rules that are affected on Ubuntu: - dconf_gnome_banner_enabled - dconf_gnome_disable_automount - dconf_gnome_disable_automount_open - dconf_gnome_disable_autorun - dconf_gnome_disable_ctrlaltdel_reboot - dconf_gnome_disable_user_list - dconf_gnome_login_banner_text - dconf_gnome_screensaver_idle_delay - dconf_gnome_screensaver_lock_delay - dconf_gnome_screensaver_lock_enabled
0ae198a
to
38c087a
Compare
/packit test |
/packit build |
/packit retest-failed |
/packit build |
/packit build |
@mpurg , currently we can't re-trigger the stalled testing-farm tests in CI, unfortunately. Could you rebase or simply amend the last commit to re-trigger them, please? |
38c087a
to
6901d00
Compare
Code Climate has analyzed commit 6901d00 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
/packit test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Description:
Modified Ubuntu profiles to enable dconf profiles
gdm
anduser
.Rationale:
On Ubuntu, dconf profiles
gdm
anduser
are not explictly configured by default. When the profiles aren't explicitlydefined and don't point to
gdm.d
andlocal.d
dconf databases, respectively, the remediations from dconf rules will have no affect on gnome settings and the checks will give false positives.The rules that are affected on Ubuntu: