Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ansible automation for configure_usbguard_auditbackend #12092

Merged

Conversation

mrkanon
Copy link
Contributor

@mrkanon mrkanon commented Jun 25, 2024

Description:

Add ansible remediation for configure_usbguard_auditbackend rule

Update all tests without the clause # packages = usbguard

Rationale:

In the task filling gaps in OL9 automation, the rule configure_usbguard_auditbackend has a remediation deficit with ansible. The parameters for the macro was taken of bash remediation.

For rule configure_usbguard_auditbackend

Signed-off-by: Armando Acosta <[email protected]>
For the configure_usbguard_auditbackend
rule test

Signed-off-by: Armando Acosta <[email protected]>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 25, 2024
Copy link

openshift-ci bot commented Jun 25, 2024

Hi @mrkanon. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New data stream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_configure_usbguard_auditbackend'.

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12092
This image was built from commit: 3649a53

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12092

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12092 make deploy-local

Copy link

codeclimate bot commented Jun 25, 2024

Code Climate has analyzed commit 3649a53 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Jun 27, 2024
@jan-cerny jan-cerny added this to the 0.1.74 milestone Jun 27, 2024
@jan-cerny jan-cerny added the Ansible Ansible remediation update. label Jun 27, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the generated Ansible tasks on RHEL 9 and I have executed Automatus against a RHEL 9 VM.

@jan-cerny jan-cerny merged commit 8bc5159 into ComplianceAsCode:master Jun 27, 2024
84 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants