Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSPP profile, use Logind session timeout feature instead of tmux #12212

Conversation

ggbecker
Copy link
Member

Description:

  • Use Logind session timeout feature to logout inactive users (this logs them out instead of locking out)

Rationale:

  • Replace tmux

@ggbecker ggbecker added the OSPP OSPP benchmark related. label Jul 23, 2024
@ggbecker ggbecker added this to the 0.1.74 milestone Jul 23, 2024
Copy link

openshift-ci bot commented Jul 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 23, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 23, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12212
This image was built from commit: 340fdc9

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12212

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12212 make deploy-local

@jan-cerny jan-cerny changed the title OSPP profile, use Logind session timeout feature instead of tmux. OSPP profile, use Logind session timeout feature instead of tmux Jul 24, 2024
@ggbecker ggbecker marked this pull request as ready for review July 24, 2024 09:22
@ggbecker ggbecker requested a review from a team as a code owner July 24, 2024 09:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 24, 2024
Add configure_bashrc_exec_tmux to default profile otherwise it would be
removed from the datastream.
@ggbecker ggbecker force-pushed the update-ospp-profile-session-timeout branch from 5681878 to 340fdc9 Compare July 24, 2024 09:25
Copy link

codeclimate bot commented Jul 24, 2024

Code Climate has analyzed commit 340fdc9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@matusmarhefka matusmarhefka self-assigned this Jul 25, 2024
@matusmarhefka matusmarhefka merged commit c189005 into ComplianceAsCode:master Jul 25, 2024
96 checks passed
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OSPP OSPP benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants