Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some issues when upgrade to sdk50 #531

Merged
merged 8 commits into from
Jun 11, 2024

Conversation

hoank101
Copy link
Collaborator

No description provided.

hoank101 and others added 8 commits May 24, 2024 19:07
Co-authored-by: dzmitry-lahoda <[email protected]>
Co-authored-by: kienn6034 <[email protected]>
Co-authored-by: rustdev <[email protected]>
Co-authored-by: rust.dev <[email protected]>
Co-authored-by: kkast <[email protected]>
Co-authored-by: Kanstantsin Kastsevich <[email protected]>
Co-authored-by: rjonczy <[email protected]>
Co-authored-by: tungle <[email protected]>
…sdk50 (#530)

add testnode.sh file that allow to run locally chain with a cosmos sdk50
…-cosmos into hoa/update-pfm

# Conflicts:
#	app/keepers/keepers.go
#	custom/ibc-transfer/keeper/keeper.go
#	x/ibctransfermiddleware/keeper/keeper.go
Comment on lines +767 to +774
for _, m := range app.mm.Modules {
if moduleWithName, ok := m.(module.HasName); ok {
moduleName := moduleWithName.Name()
if appModule, ok := moduleWithName.(appmodule.AppModule); ok {
modules[moduleName] = appModule
}
}
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
defer telemetry.ModuleMeasureSince(types.ModuleName, time.Now(), telemetry.MetricKeyEndBlocker)

return k.BlockValidatorUpdates(ctx, ctx.BlockHeight())
return k.BlockValidatorUpdates(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
@RustNinja RustNinja merged commit 8d46a51 into rustninja/pmf-middleware Jun 11, 2024
19 checks passed
@RustNinja RustNinja deleted the hoa/update-pfm branch June 11, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants