Securely added CosmWasm(CW) pallet into Picasso Runtime #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzmitry-lahoda
requested review from
blasrodri,
kkast,
RustNinja,
obsessed-cake and
krl
and removed request for
blasrodri and
kkast
blasrodri
approved these changes
May 9, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
It was set that way, I just used const instead of macro. Macro is deprecated. We tried to find where it used, went deep to stack, not researched why its so. |
|
We look may only into 4-5 parameters to setup, we need to ensure all are good at some point. |
RustNinja
approved these changes
May 9, 2023
krl
approved these changes
May 9, 2023
dzmitry-lahoda
added a commit
that referenced
this pull request
May 10, 2023
This reverts commit 422847c.
dzmitry-lahoda
added a commit
that referenced
this pull request
May 10, 2023
- picasso was added with cosmwasm pallet - it is restricted on kusama - it is easy permissionless to use on rococo - restricted some limits (see comments about issues) - partially fixed #3415 , need @kkast explanation about RPC - weights fixes would be done when we remove restriction on kusama - [x] PR title is my best effort to provide summary of changes and has clear text to be part of release notes - [x] I marked PR by `misc` label if it should not be in release notes - [x] I have linked Zenhub/Github or any other reference item if one exists - [x] I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description - [ ] I waited and did best effort for `Effect gate, automatically merged if passed`(effects-job) to finish with success(green check mark) with my changes - [x] I have added at least one reviewer in reviewers list - [ ] I tagged(@) or used other form of notification of one person who I think can handle best review of this PR --------- Co-authored-by: Obsessed Cake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picasso was added with cosmwasm pallet
it is restricted on kusama
it is easy permissionless to use on rococo
restricted some limits (see comments about issues)
partially fixed Add CosmWasm pallet to Picasso #3415 , need @kkast explanation about RPC
weights fixes would be done when we remove restriction on kusama
PR title is my best effort to provide summary of changes and has clear text to be part of release notes
I marked PR by
misclabel if it should not be in release notesI have linked Zenhub/Github or any other reference item if one exists
I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
I waited and did best effort for
Effect gate, automatically merged if passed(effects-job) to finish with success(green check mark) with my changesI have added at least one reviewer in reviewers list
I tagged(@) or used other form of notification of one person who I think can handle best review of this PR