Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lp staking #3599

Merged
merged 4 commits into from
May 12, 2023
Merged

Update lp staking #3599

merged 4 commits into from
May 12, 2023

Conversation

RustNinja
Copy link
Collaborator

@RustNinja RustNinja commented May 12, 2023

This PR related to this https://github.com/ComposableFi/Private-Issues-/issues/40

  1. Use BoundedBTreeSet instead of BTreeSet
  2. uncomment #![deny(warnings)]
  3. update tests, mock and picasso runtime with a new associated type MaxRewardCurrencies = ConstU32<10>;
  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • I have linked Zenhub/Github or any other reference item if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • I waited and did best effort for pr-workflow-check / draft-release-check to finish with success(green check mark) with my changes
  • I have added at least one reviewer in reviewers list
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR

@github-actions
Copy link

@RustNinja RustNinja added this pull request to the merge queue May 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2023
@dzmitry-lahoda dzmitry-lahoda added this pull request to the merge queue May 12, 2023
Merged via the queue into main with commit 8944c70 May 12, 2023
@dzmitry-lahoda dzmitry-lahoda deleted the update-lp-staking-after-audit branch May 12, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants