Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cw-guide #3638

Merged
merged 2 commits into from
May 25, 2023
Merged

cw-guide #3638

merged 2 commits into from
May 25, 2023

Conversation

JafarAz
Copy link
Collaborator

@JafarAz JafarAz commented May 24, 2023

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • I have linked Zenhub/Github or any other reference item if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • I waited and did best effort for pr-workflow-check / draft-release-check to finish with success(green check mark) with my changes
  • I have added at least one reviewer in reviewers list
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR

dzmitry-lahoda
dzmitry-lahoda previously approved these changes May 24, 2023
@github-actions
Copy link

github-actions bot commented May 24, 2023

@JafarAz JafarAz added this pull request to the merge queue May 25, 2023
Merged via the queue into main with commit b3c7507 May 25, 2023
@JafarAz JafarAz deleted the rococo-guide branch May 25, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants