Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcvm: merge router and gateway together #3687

Merged
merged 1 commit into from
Jun 15, 2023
Merged

xcvm: merge router and gateway together #3687

merged 1 commit into from
Jun 15, 2023

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Jun 13, 2023

The two contracts are tightly coupled and implicitly trust each other.
There’s very little gained by having them separated and merging them
simplifies development and deployment so do that.

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • I have linked Zenhub/Github or any other reference item if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • I waited and did best effort for pr-workflow-check / draft-release-check to finish with success(green check mark) with my changes
  • I have added at least one reviewer in reviewers list
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production

dzmitry-lahoda
dzmitry-lahoda previously approved these changes Jun 13, 2023
@mina86 mina86 marked this pull request as ready for review June 14, 2023 16:58
dzmitry-lahoda
dzmitry-lahoda previously approved these changes Jun 15, 2023
@dzmitry-lahoda dzmitry-lahoda added this pull request to the merge queue Jun 15, 2023
@mina86 mina86 removed this pull request from the merge queue due to a manual request Jun 15, 2023
@mina86
Copy link
Contributor Author

mina86 commented Jun 15, 2023

With #3693 merged this needs a minor fix before merging. I’ll update this PR in a moment.

@mina86
Copy link
Contributor Author

mina86 commented Jun 15, 2023

@dzmitry-lahoda, PTAL

@dzmitry-lahoda dzmitry-lahoda self-requested a review June 15, 2023 22:23
dzmitry-lahoda
dzmitry-lahoda previously approved these changes Jun 15, 2023
@mina86 mina86 added this pull request to the merge queue Jun 15, 2023
The two contracts are tightly coupled and implicitly trust each other.
There’s very little gained by having them separated and merging them
simplifies development and deployment so do that.
Merged via the queue into ComposableFi:main with commit 10f037a Jun 15, 2023
@mina86 mina86 deleted the a branch June 15, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants