Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer x.to_string() over format!("{}", x) #3689

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Prefer x.to_string() over format!("{}", x) #3689

merged 1 commit into from
Jun 13, 2023

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Jun 13, 2023 •
edited
Loading

Rust is currently unable to optimise format!("{}", x) invocations which are noticeably slower than calls to to_string method. Prefer the latter.

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • I have linked Zenhub/Github or any other reference item if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • I waited and did best effort for pr-workflow-check / draft-release-check to finish with success(green check mark) with my changes
  • I have added at least one reviewer in reviewers list
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production

@mina86
Prefer x.to_string() over format!("{}", x)
d3235fc 
Rust is currently unable to optimise `format!("{}", x)` invocations
which are noticeably slower than calls to `to_string` method.  Prefer
the latter.
@mina86 mina86 marked this pull request as ready for review June 13, 2023 16:04
@mina86 mina86 added this pull request to the merge queue Jun 13, 2023
Merged via the queue into ComposableFi:main with commit ea5a983 Jun 13, 2023
@mina86 mina86 deleted the b branch June 13, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blasrodri blasrodri blasrodri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mina86 @blasrodri