Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add symbol to list_assets rpc #3749

Merged
merged 2 commits into from
Jun 30, 2023
Merged

add symbol to list_assets rpc #3749

merged 2 commits into from
Jun 30, 2023

Conversation

kkast
Copy link
Contributor

@kkast kkast commented Jun 30, 2023

to show assets symbol correctly on FE

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • I have linked Zenhub/Github or any other reference item if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • I waited and did best effort for pr-workflow-check / draft-release-check to finish with success(green check mark) with my changes
  • I have added at least one reviewer in reviewers list
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production

RustNinja
RustNinja previously approved these changes Jun 30, 2023
@kkast kkast added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit 16b105d Jun 30, 2023
33 checks passed
@kkast kkast deleted the kkast/rpc-symbol branch June 30, 2023 23:45
kkast added a commit that referenced this pull request Jul 20, 2023
to show assets symbol correctly on FE
- [x] PR title is my best effort to provide summary of changes and has
clear text to be part of release notes
- [ ] I marked PR by `misc` label if it should not be in release notes
- [ ] I have linked Zenhub/Github or any other reference item if one
exists
- [ ] I was clear on what type of deployment required to release my
changes (node, runtime, contract, indexer, on chain operation, frontend,
infrastructure) if any in PR title or description
- [ ] I waited and did best effort for `pr-workflow-check /
draft-release-check` to finish with success(green check mark) with my
changes
- [x] I have added at least one reviewer in reviewers list
- [x] I tagged(@) or used other form of notification of one person who I
think can handle best review of this PR
- [ ] I have proved that PR has no general regressions of relevant
features and processes required to release into production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants