Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xcvm): gateway: introduce GetLocalAssetByReference query #4044

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Aug 9, 2023

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 22 10h 54m 20
RustNinja 19 1h 31m 2
blasrodri 17 1h 58m 12
kkast 11 7h 18m 4
mina86 10 23h 14m 69
vmarkushin 2 1h 8m 0
0xBrainjar2 1 3d 17h 35m 6
josietyleung 1 1d 20h 28m 3
JafarAz 1 9h 25m 0

@mina86 mina86 changed the title xcvm: gateway: introduce GetLocalAssetByReference query feat: xcvm: gateway: introduce GetLocalAssetByReference query Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4044/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4044/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4044/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4044/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4044/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

dzmitry-lahoda
dzmitry-lahoda previously approved these changes Aug 9, 2023
@mina86 mina86 enabled auto-merge August 9, 2023 20:27
@mina86 mina86 changed the title feat: xcvm: gateway: introduce GetLocalAssetByReference query feat(xcvm): gateway: introduce GetLocalAssetByReference query Aug 9, 2023
@mina86
Copy link
Contributor Author

mina86 commented Aug 10, 2023

@dzmitry-lahoda, PTAL

@mina86 mina86 added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 4ce68f0 Aug 10, 2023
33 checks passed
@mina86 mina86 deleted the mpn/b branch August 10, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants