-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xcvm): refactor protobuf handling #4108
Conversation
Pull reviewers statsStats of the last 30 days for composable:
|
# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4108/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed # run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4108/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed # CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4108/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed # run cross chain devnet with Dotsama and Cosmos nodes
nix run "github:ComposableFi/composable/refs/pull/4108/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4108/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, sorry. package cvm is right, so may be file should bve cvm.proto too.
My reasoning is that XCVM refers to the execution part, the virtual machine that runs the instructions so that’s why I went with |
Firstly, move XCVM-related protocol messages to its own package. This
will make it easier to separate protocol messages defined for other
components of the system (namely virtual wallet). Secondly, move
stuff around in the Rust code to reflect the package structure in Rust
modules. All of that is just refactoring and moving stuff around.
Lastly, replace Encodable trait by a Isomorphism trait which defines
mapping between Rust type and protocol message type together with
providing encoding and decoding methods. The latter replace custom
decode functions.
Required for merge:
pr-workflow-check / draft-release-check
is ✅ successMakes review faster:
misc
label if it should not be in release notesReviewers
@
) or used other form of notification of one person who I think can handle best review of this PR