Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xcvm): define helper proto::define_conversion macro #4112

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Sep 5, 2023

To reduce amount of boilerplate when defining conversions between
protocol buffer messages and Rust types, introduce a define_conversion
macro. It adds a TryFrom<PB> for TY and From<TY> for PB impls.

A bit of a downside of this is that it’s less obvious than an explicit
implementation of the traits. However, with many of those traits
needed I think it’s worth it.

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@mina86 mina86 added the Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform label Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 20 8h 25m 5
mina86 11 1d 34m 34
blasrodri 11 2h 35m 3
kkast 7 2h 40m 7
vmarkushin 4 7h 9m 2
RustNinja 3 1h 48m 0
JafarAz 2 9h 13m 0
0xBrainjar2 1 1d 12h 1m 0

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4112/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4112/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4112/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4112/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4112/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@mina86 mina86 merged commit 0e3f23e into main Sep 6, 2023
33 checks passed
@mina86 mina86 deleted the mpn/a branch September 6, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants