feat(xcvm): define helper proto::define_conversion macro #4112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce amount of boilerplate when defining conversions between
protocol buffer messages and Rust types, introduce a define_conversion
macro. It adds a
TryFrom<PB> for TY
andFrom<TY> for PB
impls.A bit of a downside of this is that it’s less obvious than an explicit
implementation of the traits. However, with many of those traits
needed I think it’s worth it.
Required for merge:
pr-workflow-check / draft-release-check
is ✅ successMakes review faster:
misc
label if it should not be in release notesReviewers
@
) or used other form of notification of one person who I think can handle best review of this PR