Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(runtime): update nix file and npm command #4238

Merged
merged 19 commits into from
Nov 10, 2023

Conversation

kollegian
Copy link
Contributor

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 10 9h 55m 30
RustNinja 9 17h 38m 1
kkast 7 7h 48m 5
blasrodri 5 19h 34m 1
mina86 4 1d 7h 20m 17
vmarkushin 3 2h 24m 6
JafarAz 3 39m 1
0xBrainjar2 2 6h 41m 0
fl-y 1 18h 46m 0
josietyleung 1 26m 0

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4238/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4238/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4238/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4238/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4238/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

dzmitry-lahoda
dzmitry-lahoda previously approved these changes Oct 25, 2023
@dzmitry-lahoda
Copy link
Contributor

CI is CI, it needs remote debuggin. No other option in CI. There are enterprise options to run tests clusters based on docker, we are not yet here, unless there is nice easy to inregrate provider.

@kollegian
Copy link
Contributor Author

now it is able to call centaurid and osmosisd commands. Right now it is polling every 8 seconds and timeout limit is 150 * 8 seconds. But seems channels between osmosis and centauri doesnt open in that time. Increased time limit to 250 * 8 seconds. Now trying to see if it pass.

Copy link

github-actions bot commented Nov 5, 2023

stale-pr

@github-actions github-actions bot added the Stale-item bot: Stale PRs and issues handling #owned:terraform label Nov 5, 2023
@dzmitry-lahoda
Copy link
Contributor

i did not had time to look into decomposing to reduced set of nodes and making /tmp/composable-devnet to be in run archieve yet

@github-actions github-actions bot removed the Stale-item bot: Stale PRs and issues handling #owned:terraform label Nov 6, 2023
@dzmitry-lahoda
Copy link
Contributor

@kollegian stupid question. are you blocked by me?

i am super busy before denver demo until 15 nov.

so i can show how to debug what I fold may be?

or you have something to do? like ethereum?

also I have typescript for contracts. you may play with writing some code? :)

@kollegian
Copy link
Contributor Author

@dzmitry-lahoda Currently I am working on lstaking so not blocked on this one.

@dzmitry-lahoda
Copy link
Contributor

dzmitry-lahoda commented Nov 10, 2023

@kollegian I do not have time to do all experiments now. will do in next week I guess.

can we

  1. retain/return old CURL """"test"""
  2. comment real TS tests for a while
  3. merge

cc @vladislav-terzi

@dzmitry-lahoda dzmitry-lahoda enabled auto-merge (squash) November 10, 2023 17:54
@dzmitry-lahoda dzmitry-lahoda merged commit c8713a9 into main Nov 10, 2023
35 checks passed
@dzmitry-lahoda dzmitry-lahoda deleted the tests-update-nix-file branch November 10, 2023 17:55
@dzmitry-lahoda
Copy link
Contributor

@vladislav-terzi now it is done. done when merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants