Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(addition): add architecture + stables logs for LAYR crowdloan #4418

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

JafarAz
Copy link
Collaborator

@JafarAz JafarAz commented Jan 11, 2024

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@JafarAz JafarAz added the Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform label Jan 11, 2024
@JafarAz JafarAz changed the title docs(addition) add architecture + stables logs for LAYR crowdloan docs(addition): add architecture + stables logs for LAYR crowdloan Jan 11, 2024
dzmitry-lahoda
dzmitry-lahoda previously approved these changes Jan 11, 2024
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do not know from where list of cvm addresses:) but other things ok for me

@dzmitry-lahoda
Copy link
Contributor

just retry build. it was random network failure

@JafarAz JafarAz merged commit a41291a into main Jan 11, 2024
23 checks passed
@JafarAz JafarAz deleted the add-purchase-logs branch January 11, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants