CU-1yrzbe3 - Bonded finance beneficiary #443

hussein-aitlahcen · 2022-01-04T13:10:01Z

Introduce a new beneficiary field for an offer, effectively allowing the pallet to transfer funds to the beneficiary when the maturity of an offer is Infinite
Fix a case where the cancellation would result in the remaining reward not being refunded to the issuer
Added test cases to cover the new changes

…s-helpers`

itsbobbyzz · 2022-01-04T13:10:04Z

dzmitry-lahoda

runtime code looks ok

hussein-aitlahcen added 5 commits January 4, 2022 13:29

refund remaining reward on offer cancellation

c08ed8e

remove unused errors and non required check

08d9487

introduce bond offer beneficiary

bcb83ee

introduce refund-on-cancel tests and refactor to use `composable-test…

497565d

…s-helpers`

add expected final asset owner tests

4a48e27

hussein-aitlahcen requested review from andor0, benluelo, dzmitry-lahoda, KaiserKarel and vivekvpandya January 4, 2022 13:10

dzmitry-lahoda previously approved these changes Jan 4, 2022

View reviewed changes

hussein-aitlahcen dismissed dzmitry-lahoda’s stale review via 0a68787 January 4, 2022 13:20

update benchmarking to match new changes

05f6091

hussein-aitlahcen force-pushed the bonded-finance-beneficiary branch from 0a68787 to 05f6091 Compare January 4, 2022 13:28

hussein-aitlahcen requested a review from dzmitry-lahoda January 4, 2022 13:36

benluelo previously approved these changes Jan 4, 2022

View reviewed changes

make sure cancellation is transactional

9aa9748

hussein-aitlahcen dismissed benluelo’s stale review via 9aa9748 January 4, 2022 13:58

hussein-aitlahcen requested a review from benluelo January 4, 2022 13:58

dzmitry-lahoda approved these changes Jan 4, 2022

View reviewed changes

KaiserKarel approved these changes Jan 5, 2022

View reviewed changes

KaiserKarel merged commit a150c48 into main Jan 5, 2022

KaiserKarel deleted the bonded-finance-beneficiary branch January 5, 2022 11:38

Provide feedback