Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-1n09gg7 Integrate code coverage with CI #445

Merged
merged 6 commits into from
Jan 6, 2022
Merged

Conversation

aettran
Copy link
Contributor

@aettran aettran commented Jan 5, 2022

Adding code coverage with CI

Oleksii Filonenko and others added 4 commits January 4, 2022 23:08
Remove --all-features from llvm-cov command

Combine "Unit test" and "Test coverage" CI jobs

Use CODECOV_TOKEN
@aettran aettran changed the title vj/coverage ci Integrate code coverage with CI Jan 5, 2022
@aettran aettran changed the title Integrate code coverage with CI CU-1tt5q2a Integrate code coverage with CI Jan 5, 2022
@itsbobbyzz
Copy link

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@b46e402). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage        ?   62.06%           
=======================================
  Files           ?      142           
  Lines           ?    21568           
  Branches        ?        0           
=======================================
  Hits            ?    13386           
  Misses          ?     8182           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46e402...8e56154. Read the comment docs.

@aettran aettran changed the title CU-1tt5q2a Integrate code coverage with CI CU-1n09gg7 Integrate code coverage with CI Jan 5, 2022
Copy link
Contributor

@KaiserKarel KaiserKarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove usage of actions-rs, as we'd need to manually update every toolchain input in CI whenever we upgrade rust versions

@dzmitry-lahoda dzmitry-lahoda self-requested a review January 6, 2022 10:53
@KaiserKarel KaiserKarel merged commit adab265 into main Jan 6, 2022
@KaiserKarel KaiserKarel deleted the vj/coverage-ci branch January 6, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants