Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HashedDescription XCM converter and remove TinkernetMultisig configs #4450

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

arrudagates
Copy link
Contributor

This PR adds the common XCM location converter HashedDescription, which is used across the ecosystem, to Picasso.
Since the current Polkadot SDK version in use does not contain these configs, they are temporarily pulled locally into parachains/runtime/common and added to the Picasso runtime from the common local crate.

For reference, chains using HashedDescription include the relay chain and system parachains like the Asset Hub.

Another chain also using HashedDescription but pulling it from a later Polkadot SDK version is Astar

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@arrudagates arrudagates changed the title Add HashedDescription XCM converter and remove TinkernetMultisig configs feat: Add HashedDescription XCM converter and remove TinkernetMultisig configs Feb 15, 2024
@dzmitry-lahoda
Copy link
Contributor

@arrudagates thank you

Copy link

stale-pr

@github-actions github-actions bot added the Stale-item bot: Stale PRs and issues handling #owned:terraform label Feb 24, 2024
@dzmitry-lahoda dzmitry-lahoda requested review from kkast and RustNinja and removed request for dzmitry-lahoda February 24, 2024 12:03
@github-actions github-actions bot removed the Stale-item bot: Stale PRs and issues handling #owned:terraform label Feb 25, 2024
Copy link

github-actions bot commented Mar 3, 2024

stale-pr

@github-actions github-actions bot added Stale-item bot: Stale PRs and issues handling #owned:terraform and removed Stale-item bot: Stale PRs and issues handling #owned:terraform labels Mar 3, 2024
Copy link

stale-pr

@github-actions github-actions bot added the Stale-item bot: Stale PRs and issues handling #owned:terraform label Mar 10, 2024
@arrudagates
Copy link
Contributor Author

@RustNinja Any blockers on this?

@dzmitry-lahoda dzmitry-lahoda merged commit a46e9da into ComposableFi:main Mar 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale-item bot: Stale PRs and issues handling #owned:terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants