Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): fix link to RELEASE.md #4468

Merged
merged 1 commit into from
Mar 22, 2024
Merged

docs(readme): fix link to RELEASE.md #4468

merged 1 commit into from
Mar 22, 2024

Conversation

umbr4g3
Copy link
Contributor

@umbr4g3 umbr4g3 commented Mar 22, 2024

I noticed a link was broken while reading through the docs, so I fixed it.

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@dzmitry-lahoda dzmitry-lahoda merged commit cb505f2 into ComposableFi:main Mar 22, 2024
16 of 18 checks passed
@umbr4g3 umbr4g3 deleted the patch-1 branch March 23, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants