CU-1tmym8b - Refactor crowdloan rewards #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hussein-aitlahcen
commented
Jan 10, 2022
hussein-aitlahcen
commented
- unsigned origin for association
- check for already associated account
- remove legacy prefix
- refactor tests/benchmarks to reuse structures/code
…ated structures/code
hussein-aitlahcen
force-pushed
the
refactor-crowdloan-rewards
branch
from
deacbaf
to
6ef3954
Compare
hussein-aitlahcen
requested review from
cor,
andor0,
dzmitry-lahoda,
KaiserKarel and
seunlanlege
KaiserKarel
reviewed
Jan 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #463 +/- ##
=======================================
Coverage ? 60.41%
=======================================
Files ? 141
Lines ? 20335
Branches ? 0
=======================================
Hits ? 12285
Misses ? 8050
Partials ? 0 Continue to review full report at Codecov.
|
KaiserKarel
approved these changes
Jan 10, 2022
andor0
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.