Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farmer support for network interface #1039

Merged
merged 5 commits into from
Jun 5, 2023

Conversation

Huaxinli123
Copy link
Contributor

@Huaxinli123 Huaxinli123 commented May 30, 2023

This PR closes #

The changes in this PR are as follows:

  • Adding support for azure network interface
  • Support both dynamic and static ip allocation

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

#r "nuget:Farmer"
open Farmer
open Farmer.Builders
open Farmer.Builders.NetworkInterface

arm {
    location Location.EastUS
    add_resources
        [
            vnet {
                name "test-vnet"
                add_address_spaces [ "10.0.0.0/16" ]
            }
            networkInterface {
                name "my-network-interface"
                subnet_prefix "10.0.100.0/24"
                link_to_vnet (virtualNetworks.resourceId "test-vnet")
                add_static_ip "10.0.100.10"
                accelerated_networking_flag false
                ip_forwarding_flag false
            }
        ]
}

@Huaxinli123 Huaxinli123 changed the title Farmer support for ni Farmer support for network interface May 30, 2023
@Huaxinli123 Huaxinli123 marked this pull request as ready for review May 31, 2023 17:26
@ninjarobot ninjarobot added this to the 1.7.23 milestone Jun 1, 2023
Copy link
Collaborator

@ninjarobot ninjarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Huaxinli123 thanks again for this PR. The code, tests, and docs look good, just have a few questions about the functionality.

src/Farmer/Builders/Builders.NetworkInterface.fs Outdated Show resolved Hide resolved
src/Farmer/Builders/Builders.NetworkInterface.fs Outdated Show resolved Hide resolved
src/Farmer/Builders/Builders.NetworkInterface.fs Outdated Show resolved Hide resolved
@ninjarobot ninjarobot modified the milestones: 1.7.23, 1.7.24 Jun 5, 2023
@ninjarobot
Copy link
Collaborator

@Huaxinli123 can you please resolve the conflicts in the network tests since merging your prior PR?

Copy link
Collaborator

@ninjarobot ninjarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing those. Once the merge conflicts are resolved, this is ready to merge.

@ninjarobot ninjarobot merged commit e616e34 into CompositionalIT:master Jun 5, 2023
github-actions bot pushed a commit that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants