Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "supports https traffic only" property storage accounts #1108

Conversation

fahedmarakbi
Copy link
Contributor

@fahedmarakbi fahedmarakbi commented Jun 4, 2024

This PR closes #1107

The changes in this PR are as follows:

  • Add SupportsHttpsTrafficOnly property support to Storage Account resource

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

storageAccount {
    name "mystorage123"
    supports_https_traffic_only
}

@ninjarobot ninjarobot added this to the 1.8.11 milestone Jun 4, 2024
@fahedmarakbi fahedmarakbi changed the title Add supports https traffic property storage accounts Add "supports https traffic only" property storage accounts Jun 4, 2024
@ninjarobot
Copy link
Collaborator

I tested this out in codespaces to make sure it worked as expected and did not regress anything:

let deployment = 
    arm {
        location Location.EastUS
        add_resources [
            storageAccount {
                name "mystorage03489https"
                supports_https_traffic_only
            }
            storageAccount {
                name "mystorage123abchttp"
                supports_https_traffic_only Disabled
            }
            storageAccount {
                name "mystorage123abcdefault"
            }
        ]
    }
deployment |> Writer.quickWrite "sb-secure-transit"

With HTTPS required:
image

With HTTPS disabled:
image

Default (enables it as well):
image

Copy link
Collaborator

@ninjarobot ninjarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this contribution @fahedmarakbi !

@ninjarobot ninjarobot merged commit 228781f into CompositionalIT:master Jun 9, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 9, 2024
…-property-storage-accounts

Add "supports https traffic only" property storage accounts 228781f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SupportsHttpsTrafficOnly property support for storage accounts
2 participants