Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plural storage containers #1119

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

Tarmil
Copy link
Contributor

@Tarmil Tarmil commented Jun 26, 2024

The changes in this PR are as follows:

  • Storage: add plural add_blob_containers, add_public_containers, add_private_containers, add_file_shares, add_file_shares_with_quota and add_queues (string seq).
  • Storage: fix quadratic complexity in add_queues (StorageQueueConfig seq).

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

let account = storageAccount {
    add_blob_containers [ "blob1"; "blob2" ]
    add_public_containers [ "public1"; "public2" ]
    add_private_containers [ "private1"; "private2" ]
    add_file_shares [ "share1"; "share2" ]
    add_file_shares_with_quota [ "share3"; "share4" ] 1024<Gb>
    add_queues [ "queue1"; "queue2" ]
}

@ninjarobot ninjarobot added this to the 1.8.13 milestone Jul 1, 2024
Copy link
Collaborator

@ninjarobot ninjarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for including tests and docs over the changes.

Would it simplify the code to change the various fields in StorageAccountConfig to Set types instead of lists? Then they will remain distinct even as people call these operations multiple times.

@ninjarobot ninjarobot merged commit d8cbb69 into CompositionalIT:master Jul 3, 2024
3 checks passed
@Tarmil Tarmil deleted the add-storage-containers branch July 3, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants