Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker port setting for app service #870

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

stevebelskie
Copy link
Contributor

This PR closes #869

The changes in this PR are as follows:

  • Adds support for specifying a custom docker port for an app service

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

let wa = webApp {
    name "myApp"
    docker_port 8080
}

@isaacabraham
Copy link
Member

This looks great! I'll do a proper code review this week - probably just some syntactic style changes but this looks very good.

Thank you very much.

@stevebelskie
Copy link
Contributor Author

Happy to help! Still getting used to F# so there were a few places I wasn't sure about what would be idiomatic, but overall the code base is incredibly well laid out and it was pretty easy to figure out what goes where.

I'll definitely be contributing to (and using!) Farmer more in the future.

@isaacabraham isaacabraham merged commit 63673cd into CompositionalIT:master Feb 11, 2022
github-actions bot pushed a commit that referenced this pull request Feb 11, 2022
Add docker port setting for app service 63673cd
@ninjarobot
Copy link
Collaborator

Thank you, this is released now in 1.6.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docker port keyword to app service
3 participants