-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for App Insights workspaces #895
Conversation
@xdaDaveShaw can you have a look at this - I'm hopeful it does what you're after, too. Let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for adding test coverage over the classic and new resource types.
@ninjarobot do you know if we need to keep the old API version - can we just start using the new ARM schema version for both classic and workspace AI? That would simplify some code. |
Support for App Insights workspaces 7e281ce
The old API version will make a classic instance, so best not to use that. We may want to consider dropping it from Farmer, though, just because people probably should not be deploying those anymore. |
Thanks for adding this, it's now released in farmer 1.6.30. |
Thanks @isaacabraham - this looks great. Sorry I couldn't reply sooner, had a busy week. |
This PR closes #770
The changes in this PR are as follows:
I have read the contributing guidelines and have completed the following:
Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure: