Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for App Insights workspaces #895

Merged
merged 6 commits into from
Mar 15, 2022
Merged

Support for App Insights workspaces #895

merged 6 commits into from
Mar 15, 2022

Conversation

isaacabraham
Copy link
Member

This PR closes #770

The changes in this PR are as follows:

  • Adds an extra keyword for linking a Log Analytics Workspace to an App Instance instance.

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

let workspace = logAnalytics {
    name "loganalytics-workspace"
}

let myAppInsights = appInsights {
    name "appInsights"
    log_analytics_workspace workspace
}

@isaacabraham isaacabraham self-assigned this Mar 13, 2022
@isaacabraham isaacabraham modified the milestone: 1.6.30 Mar 13, 2022
@isaacabraham
Copy link
Member Author

@xdaDaveShaw can you have a look at this - I'm hopeful it does what you're after, too. Let me know.

Copy link
Collaborator

@ninjarobot ninjarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for adding test coverage over the classic and new resource types.

@ninjarobot ninjarobot added this to the 1.6.30 milestone Mar 14, 2022
@isaacabraham
Copy link
Member Author

@ninjarobot do you know if we need to keep the old API version - can we just start using the new ARM schema version for both classic and workspace AI? That would simplify some code.

@isaacabraham isaacabraham merged commit 7e281ce into master Mar 15, 2022
@isaacabraham isaacabraham deleted the ai-workspaces branch March 15, 2022 15:14
github-actions bot pushed a commit that referenced this pull request Mar 15, 2022
@ninjarobot
Copy link
Collaborator

@ninjarobot do you know if we need to keep the old API version - can we just start using the new ARM schema version for both classic and workspace AI? That would simplify some code.

The old API version will make a classic instance, so best not to use that. We may want to consider dropping it from Farmer, though, just because people probably should not be deploying those anymore.

@ninjarobot
Copy link
Collaborator

Thanks for adding this, it's now released in farmer 1.6.30.

@xdaDaveShaw
Copy link

Thanks @isaacabraham - this looks great.

Sorry I couldn't reply sooner, had a busy week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace-based Application Insights resources
3 participants