Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null priority to allow updating non-spot VM instances #969

Merged
merged 5 commits into from
Sep 9, 2022
Merged

Allow null priority to allow updating non-spot VM instances #969

merged 5 commits into from
Sep 9, 2022

Conversation

TheRSP
Copy link
Contributor

@TheRSP TheRSP commented Sep 2, 2022

This PR closes #894

The changes in this PR are as follows:

  • Don't set VM priority unless explicitly opted in to so that non-spot instances still work

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

vm {
  name "myvm"
  username "me"
}

@ninjarobot ninjarobot merged commit 04b8ad1 into CompositionalIT:master Sep 9, 2022
github-actions bot pushed a commit that referenced this pull request Sep 9, 2022
@ninjarobot
Merge pull request #969 from codatio/allow-null-priority
058daa1 
Allow null priority to allow updating non-spot VM instances 04b8ad1
@ninjarobot ninjarobot modified the milestones: 1.7.9, 1.7.8 Sep 9, 2022
@ninjarobot
Copy link
Collaborator

Thanks for the contribution, this is included in the 1.7.8 release and now available on nuget!

@ninjarobot ninjarobot mentioned this pull request Sep 10, 2022
Closed
thinkdavid added a commit to thinkdavid/farmer that referenced this pull request Oct 11, 2022
@thinkdavid
Squashed commit of the following:
78bf429 
commit c230525
Author: Dave Curylo <[email protected]>
Date:   Wed Sep 28 22:29:43 2022 -0400

    Release 1.7.10

commit a817582
Merge: 5733c56 fbf8231
Author: Dave Curylo <[email protected]>
Date:   Wed Sep 28 18:34:03 2022 -0400

    Merge pull request CompositionalIT#979 from ahmed-ebaid/link_to_identity

commit fbf8231
Author: Ahmed Ebaid <[email protected]>
Date:   Wed Sep 28 17:20:50 2022 -0500

    Running fantomas on UserAssignedIdentity

commit 436d6d3
Author: Ahmed Ebaid <[email protected]>
Date:   Wed Sep 28 15:28:31 2022 -0500

    Refactor code to leverage LinkedUserAssignedIdentity

commit 1ed920e
Author: Dave Curylo <[email protected]>
Date:   Wed Sep 28 15:24:09 2022 -0400

    Reformatting for fantomas

commit 667d0e8
Author: Dave Curylo <[email protected]>
Date:   Wed Sep 28 15:06:48 2022 -0400

    The LinkedUserAssignedIdentity is always unmanaged.

commit 00fe027
Author: Dave Curylo <[email protected]>
Date:   Wed Sep 28 11:54:36 2022 -0400

    Adds LinkedUserAssignedIdentity for backwards compatibility

commit d28f4eb
Author: Ahmed Ebaid <[email protected]>
Date:   Tue Sep 27 12:25:39 2022 -0500

    Fix documentation

commit 864d5ed
Author: Ahmed Ebaid <[email protected]>
Date:   Tue Sep 27 07:13:41 2022 -0500

    Add additional testing

commit 62f5978
Author: Ahmed Ebaid <[email protected]>
Date:   Mon Sep 26 20:38:41 2022 -0500

    Fixing documen

commit 4061e63
Author: Ahmed Ebaid <[email protected]>
Date:   Mon Sep 26 20:10:01 2022 -0500

    Run fantomas on changed files

commit 652b99c
Author: Ahmed Ebaid <[email protected]>
Date:   Mon Sep 26 16:44:50 2022 -0500

    Adding more testing and updating documentation

commit 4974949
Author: Ahmed Ebaid <[email protected]>
Date:   Mon Sep 26 15:29:17 2022 -0500

    Removing changes from Common.fs

commit b4e09e2
Author: Ahmed Ebaid <[email protected]>
Date:   Mon Sep 26 15:26:19 2022 -0500

    Initial work for linking to an identity

commit 5733c56
Author: Dave Curylo <[email protected]>
Date:   Thu Sep 22 11:16:18 2022 -0400

    1.7.9 release

commit 65b5e79
Merge: 043ee73 1afcf28
Author: Dave Curylo <[email protected]>
Date:   Wed Sep 21 22:00:34 2022 -0400

    Merge pull request CompositionalIT#967 from codatio/fix-nic-subnet-rg

commit 1afcf28
Merge: d196321 043ee73
Author: Richard Sanderson-Pope <[email protected]>
Date:   Wed Sep 21 21:27:35 2022 +0100

    merge

commit 043ee73
Merge: c9c3a9d f1c215e
Author: Dave Curylo <[email protected]>
Date:   Wed Sep 21 09:43:51 2022 -0400

    Merge pull request CompositionalIT#977 from ahmed-ebaid/managed_identity_support

    ACR Managed Identity Support for Container Groups and Container Apps

commit f1c215e
Author: Ahmed Ebaid <[email protected]>
Date:   Tue Sep 20 18:08:39 2022 -0500

    Format files with fantomas

commit 84e99c3
Author: Ahmed Ebaid <[email protected]>
Date:   Tue Sep 20 17:32:03 2022 -0500

    Updating documentation and release notes

commit 81bf829
Author: Ahmed Ebaid <[email protected]>
Date:   Tue Sep 20 17:30:08 2022 -0500

    Uopdate documentation

commit 49a1214
Author: Ahmed Ebaid <[email protected]>
Date:   Tue Sep 20 17:18:58 2022 -0500

    Fix failing logic

commit 5c8b9ba
Author: Ahmed Ebaid <[email protected]>
Date:   Mon Sep 19 17:13:21 2022 -0500

    Modify test to add identity

commit 9738e06
Author: Ahmed Ebaid <[email protected]>
Date:   Mon Sep 19 16:19:47 2022 -0500

    Add managed identity support for containers groupd and container apps

commit c9c3a9d
Merge: 3b1d08e ef578a9
Author: Isaac Abraham <[email protected]>
Date:   Fri Sep 16 11:02:55 2022 +0100

    Merge pull request CompositionalIT#975 from CompositionalIT/teknikal-wizard-patch-1

    Update storage-account.md

commit ef578a9
Author: Ryan Palmer <[email protected]>
Date:   Fri Sep 16 10:32:01 2022 +0100

    Update storage-account.md

    Added documentation of ip and subnet restriction functionality, addressing CompositionalIT#951

commit 3b1d08e
Author: david becher <[email protected]>
Date:   Fri Sep 9 10:14:01 2022 -0700

    Update docs to coincide with the last minute change to HopType

commit a39dbd8
Author: Dave Curylo <[email protected]>
Date:   Fri Sep 9 10:46:00 2022 -0400

    Release 1.7.8

commit 6ab3f7c
Author: Dave Curylo <[email protected]>
Date:   Thu Sep 8 23:12:21 2022 -0400

    Cleanup resource naming in release notes

commit 99f62b4
Author: Dave Curylo <[email protected]>
Date:   Thu Sep 8 23:10:14 2022 -0400

    Cleanup release notes

commit 04b8ad1
Merge: 7c98806 75c3d09
Author: Dave Curylo <[email protected]>
Date:   Thu Sep 8 23:07:07 2022 -0400

    Merge pull request CompositionalIT#969 from codatio/allow-null-priority

    Allow null priority to allow updating non-spot VM instances

commit 7c98806
Author: Dave Curylo <[email protected]>
Date:   Thu Sep 8 23:06:27 2022 -0400

    Cleanup release notes

commit 3c4aa3f
Merge: aa4dafe 81ce474
Author: Dave Curylo <[email protected]>
Date:   Thu Sep 8 22:50:01 2022 -0400

    Merge pull request CompositionalIT#972 from thinkdavid/thinkdavid/routeTables

    Adding support for route tables and their child resource, routes

commit 81ce474
Author: david becher <[email protected]>
Date:   Thu Sep 8 14:06:16 2022 -0700

    Making NextHopType include IPAddress if NextHopType is VA

commit a069779
Author: david becher <[email protected]>
Date:   Thu Sep 8 11:25:10 2022 -0700

    formatting ran

commit 1aa0f65
Author: david becher <[email protected]>
Date:   Thu Sep 8 11:22:57 2022 -0700

    Document update

commit ddcae2f
Author: david becher <[email protected]>
Date:   Wed Sep 7 15:56:03 2022 -0700

    Validated in ARM

commit a93c2e7
Author: david becher <[email protected]>
Date:   Wed Sep 7 15:28:13 2022 -0700

    Unit tests passed

commit e068e84
Author: david becher <[email protected]>
Date:   Wed Sep 7 13:55:08 2022 -0700

    Update Builders.RouteTable.fs

commit f4d52f4
Author: david becher <[email protected]>
Date:   Wed Sep 7 13:54:47 2022 -0700

    Update Builders.RouteTable.fs

commit 394d9b3
Author: david becher <[email protected]>
Date:   Wed Sep 7 13:54:23 2022 -0700

    Ready for testing

commit df95a0b
Author: david becher <[email protected]>
Date:   Tue Sep 6 17:07:20 2022 -0700

    None is reserved for Option

commit 01fee70
Author: david becher <[email protected]>
Date:   Tue Sep 6 16:46:22 2022 -0700

    Finished enum for NextHopType and added the formatting of the ip address

commit 817e923
Author: david becher <[email protected]>
Date:   Tue Sep 6 16:38:26 2022 -0700

    Minor refactoring

commit 903b8ed
Author: david becher <[email protected]>
Date:   Tue Sep 6 15:47:21 2022 -0700

    Starting code for the route tables addition

commit 75c3d09
Author: Richard Sanderson-Pope <[email protected]>
Date:   Fri Sep 2 14:30:51 2022 +0100

    Fix regression tests

commit b274b6f
Author: Richard Sanderson-Pope <[email protected]>
Date:   Fri Sep 2 14:13:40 2022 +0100

    reformat

commit d196321
Author: Richard Sanderson-Pope <[email protected]>
Date:   Fri Sep 2 14:11:48 2022 +0100

    reformat

commit da7c83b
Author: Richard Sanderson-Pope <[email protected]>
Date:   Fri Sep 2 14:09:01 2022 +0100

    update docs

commit e90b1c3
Author: Richard Sanderson-Pope <[email protected]>
Date:   Fri Sep 2 14:07:21 2022 +0100

    Add tests and release notes

commit 11590e1
Author: Richard Sanderson-Pope <[email protected]>
Date:   Fri Sep 2 12:21:15 2022 +0100

    Allow null priority to allow updating non-spot VM instances

commit 323f62f
Author: Richard Sanderson-Pope <[email protected]>
Date:   Fri Sep 2 11:37:43 2022 +0100

    Add release notes

commit 162845e
Author: Richard Sanderson-Pope <[email protected]>
Date:   Fri Sep 2 11:34:04 2022 +0100

    Add tests

commit 684760c
Author: Richard Sanderson-Pope <[email protected]>
Date:   Fri Sep 2 11:15:19 2022 +0100

    Keep RG and Subs components from VNet when generating a subnet resourceId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninjarobot ninjarobot ninjarobot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.8
Development

Successfully merging this pull request may close these issues.
2 participants
@TheRSP @ninjarobot