Workaround Ray dependency conflict #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Published versions of ray require pydantic<2, but they have not pinned versions
garrettwrong
added
bug
|
Great, planning to merge this in as soon as the CI is green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1065 +/- ##
========================================
Coverage 89.08% 89.08%
========================================
Files 126 126
Lines 11965 11965
========================================
Hits 10659 10659
Misses 1306 1306 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found Ray was failing to initialize for our large integration tests (ie, our experimental data reconstructions) in recently made environments.
Tracked it to ray-project/ray#37019.
The recommended workaround is simple and seems to work for us, but somewhat annoying (that we need to manage more external package depends). I will make an issue to followup post
ray=2.9.1.The
pillowline was just moved to improve the depends lexi sort.