cupla: no .gitmodules #2547
Merged
cupla: no .gitmodules #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the .gitmodules file from cupla. We ship alpaka ourselves and it can confuse git clone steps to have it in there. First seen as an issue with ReadTheDocs builds (activated by default since November last year).
ax3l
added
bug
ax3l
commented
Mar 10, 2018
| @@ -1,4 +0,0 @@ | |||
| [submodule "alpaka"] | |||
| path = alpaka | |||
| url = git://github.com/ComputationalRadiationPhysics/alpaka.git | |||
There was a problem hiding this comment.
@psychocoderHPC you might also want to consider adding this url to a https:// url on cupla itself.
Otherwise, anonymous git clones (--recursive) and git submodule init, update, sync, etc. will fail for cupla.
|
I am confused because you change a thridt party module. We never change this directly in our project. |
|
Yes I know, but git subtree is really that simple and allows that :)
|
|
If we forget it on an update and RTD did not expose the linked issue as an option by then, the badge in the readme will tell us |
|
offline discussed: this is a temporary solution. In general we should not update our thrid party dependencies here. |
psychocoderHPC
approved these changes
Mar 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the .gitmodules file from cupla. We ship alpaka ourselves and it can confuse git clone steps to have it in there.
First seen as an issue with ReadTheDocs builds (activated by default since November last year).