Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed schema by default #177

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Embed schema by default #177

merged 6 commits into from
Jul 2, 2024

Conversation

lassemoldrup
Copy link
Contributor

Purpose

Closes #173. The branch is branched out from #176.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@DOBEN DOBEN self-requested a review June 28, 2024 12:14
DOBEN
DOBEN approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, we should update our developer documentation and remove the deprecated flag from the commands. Just not immediately since most people will still be using older versions of cargo-concordium.

cargo-concordium/CHANGELOG.md Outdated Show resolved Hide resolved
cargo-concordium/src/main.rs Outdated Show resolved Hide resolved
@lassemoldrup lassemoldrup mentioned this pull request Jul 2, 2024
Open
@lassemoldrup lassemoldrup merged commit 6bb7114 into main Jul 2, 2024
@lassemoldrup lassemoldrup deleted the embed-schema-by-default branch July 2, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limemloh limemloh limemloh approved these changes

@DOBEN DOBEN DOBEN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cargo-concordium: embed schema by default
3 participants
@lassemoldrup @limemloh @DOBEN