Dependency optimizations #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tried out the prebuilt lightwallet.min.js from this PR and it locks up my browser upon txutil.functionTx & signTx. |
| @@ -284,7 +281,7 @@ KeyStore.generateRandomSeed = function(extraEntropy) { | |||
| } | |||
| else if (typeof extraEntropy === 'string') { | |||
| var entBuf = new Buffer(extraEntropy); | |||
| var randBuf = Random.getRandomBuffer(256 / 8); | |||
| var randBuf = nacl.randomBytes(256 / 8); | |||
There was a problem hiding this comment.
Will this work? It's of type Uint8Array and not Buffer
Masperoo
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the following
It lowers the size of the minimized version from 160k to 105k