Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up MulByXXX methods, hard-coded non-residue constants in the template generator #10

Merged
merged 23 commits into from
Jul 10, 2020
Merged

Clean up MulByXXX methods, hard-coded non-residue constants in the template generator #10

merged 23 commits into from
Jul 10, 2020

Commits on Jun 22, 2020

  1. refactor-constants: collapste template fpMulByNonResidueBody into tem… 

    …plate fpInlineMulByNonResidue, clean up generated comments
    @ggutoski
    ggutoski committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    874c8b0 View commit details
    Browse the repository at this point in the history

  2. refactor-constants: collapste template fpMulByNonResidueInvBody into … 

    …template fpInlineMulByNonResidueInv, more comment cleaning
    @ggutoski
    ggutoski committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    b05bbe5 View commit details
    Browse the repository at this point in the history

  3. refactor-constants: collapse template fp2MulByNonResidueBody into tem… 

    …plate fp2InlineMulByNonResidue
    @ggutoski
    ggutoski committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    5b7287d View commit details
    Browse the repository at this point in the history

  4. refactor-constants: collapse template fp2MulByNonResidueBodyInv into … 

    …template fp2InlineMulByNonResidueInv, clean up some dollar signs
    @ggutoski
    ggutoski committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    51af765 View commit details
    Browse the repository at this point in the history

  5. refactor-constants: collapse template fp6MulByNonResidueBody into tem… 

    …plate fp6InlineMulByNonResidue
    @ggutoski
    ggutoski committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    ae84086 View commit details
    Browse the repository at this point in the history

  6. refactor-constants: fix bug in MulByNonResidueInv for bls381, bn256; … 

    …good thing no one called this code; good thing we had tests... :rolleyes:
    @ggutoski
    ggutoski committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    20bd4b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. refactor-constants: bls377: move MulByVW, MulByV, MulByV2W from e12.g… 

    …o to pairing.go, delete MulByV2NRInv, MulByNWNRInv, MulByWNRInv
    @ggutoski
    ggutoski committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    c4f76c1 View commit details
    Browse the repository at this point in the history

  2. refactor-constants: same as above for bls381, bn256

    @ggutoski
    ggutoski committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    937b8c0 View commit details
    Browse the repository at this point in the history

  3. refactor-constants: port the above changes into the template generato… 

    …r, regenerate code to ensure it's correct
    @ggutoski
    ggutoski committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    6fd64e1 View commit details
    Browse the repository at this point in the history

  4. refactor-constants: bls377: regenerate tests for e12 by tweaking gnar… 

    …k commit 7dcd496ba42799bf1d4b695226ce6cc4c1f48792
    @ggutoski
    ggutoski committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    81a3498 View commit details
    Browse the repository at this point in the history

  5. refactor-constants: same as above for bls381, bn256

    @ggutoski
    ggutoski committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    dcd856e View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. refactor-constants: bw761: replace fourinv string conversion with har… 

    …d-coded value
    @ggutoski
    ggutoski committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7bb0b2e View commit details
    Browse the repository at this point in the history

  2. refactor-constants: bw761: remove MulByXXX, embed their bodies direct… 

    …ly into mulAssign, add some comments
    @ggutoski
    ggutoski committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    237f5ed View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. refactor-constants: comment out MulByNotv2 from the template generator

    @ggutoski
    ggutoski committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    8fb84dd View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. refactor-constants: e2 template: remove MulByNonResidue, MulByNonResi… 

    …dueInv methods; inline them instead
    @ggutoski
    ggutoski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    caeff3f View commit details
    Browse the repository at this point in the history

  2. refactor-constants: e6 template: remove MulByNonResidue, MulByNonResi… 

    …dueInv methods
    @ggutoski
    ggutoski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    43ed0ea View commit details
    Browse the repository at this point in the history

  3. refactor-constants: e2 template: comment out fpInlineMulByNonResidueI… 

    …nv template
    @ggutoski
    ggutoski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    76bb417 View commit details
    Browse the repository at this point in the history

  4. refactor-constants: e2 template: switch comment with panic() for easy… 

    … detection in the future
    @ggutoski
    ggutoski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    63bc76d View commit details
    Browse the repository at this point in the history

  5. refactor-constants: e12 template: comment out MulByNonResidue method

    @ggutoski
    ggutoski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    dac7e42 View commit details
    Browse the repository at this point in the history

  6. refactor-constants: template generator: delete TwoInv code

    @ggutoski
    ggutoski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    dcad61c View commit details
    Browse the repository at this point in the history

  7. refactor-constants: template generator: delete commented-out template… 

    …s for MulByNonResidue
    @ggutoski
    ggutoski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    115c81d View commit details
    Browse the repository at this point in the history

  8. refactor-constants: bls381/pairing.go: refactor twoInv into a new mul… 

    …ByNonResidueInv helper
    @ggutoski
    ggutoski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    70e1668 View commit details
    Browse the repository at this point in the history

  9. refactor-constants: replace E12, E2 with PairingResult, G2CoordType

    @ggutoski
    ggutoski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    0e856c4 View commit details
    Browse the repository at this point in the history