Refactor/breakup pedersen #383
Conversation
| @@ -209,15 +209,17 @@ func (z *E12) DecompressKarabina(x *E12) *E12 { | |||
| var one E2 | |||
| one.SetOne() | |||
|
|
|||
| // g3 == 0 | |||
| if x.C1.B2.IsZero() { | |||
| if x.C1.B2.IsZero() /* g3 == 0 */ { | |||
There was a problem hiding this comment.
did you measure these changes on e6.go ? That may affect pairing perf --
Also not sure why this is in this PR?
There was a problem hiding this comment.
I must have merged in something from an experimental branch. Will try to "unbase".
| } | ||
|
|
||
| func randomOnG2() (curve.G2Affine, error) { // TODO: Add to G2.go? | ||
| if gBytes, err := randomFrSizedBytes(); err == nil { |
There was a problem hiding this comment.
this is me nit picking but, the usual pattern we see in go code bases is
if err != nil {return error} --> (else) return result.
(and not the opposite :p )
There was a problem hiding this comment.
I thought since I was using both conditions it would be nice to consider the full half of the glass first for a change. 😁
| return enc.BytesWritten(), err | ||
| } | ||
|
|
||
| for i := range pk.basis { |
There was a problem hiding this comment.
can encode the slice directly (ie pass the slice as an argument to Encode) rather than a for loop on each element.
Same for decode.
| return {{.CurvePackage}}.G1Affine{}, err | ||
| func randomOnG1() (curve.G1Affine, error) { // TODO: Add to G1.go? | ||
| if gBytes, err := randomFrSizedBytes(); err == nil { | ||
| return curve.HashToG1(gBytes, []byte("random on g1")) |
There was a problem hiding this comment.
same remark; usual pattern is "if error -> return error"
|
See #384 instead |
Similar to #378 but for Pedersen commitments instead of KZG. When commitments are used, the verifier needs to check a proof of knowledge of commitment. However, only two G2 elements are required for this, and we should thus avoid storing a long slice of G1 elements inside the verifying key.