Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe length extension attack for MiMC hash function. #520

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Jul 12, 2024

Description

This PR adds documentation to emphasize the potential issues when using MiMC. Also references issues in gnark-crypto about the format of inputs.

Type of change

  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added cleanup Suggestion to clean up the code consolidate strengthen an existing feature labels Jul 12, 2024
@ivokub ivokub requested a review from gbotrel July 12, 2024 12:01
@ivokub ivokub self-assigned this Jul 12, 2024
@gbotrel gbotrel merged commit 7e5f929 into master Jul 18, 2024
7 checks passed
@gbotrel gbotrel deleted the docs/mimc-lengthextension branch July 18, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Suggestion to clean up the code consolidate strengthen an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants