Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-native arithmetic with variable modulus various fixes #1104

Merged
merged 1 commit into from
May 14, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Apr 22, 2024

Description

This PR collects various fixes to non-native arithmetic with variable modulus:

  • in case the provided variable modulus in non-native arithmetic is zero, then return more descriptive panic trace

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added the bug Something isn't working label Apr 22, 2024
@ivokub ivokub self-assigned this Apr 22, 2024
@ivokub ivokub marked this pull request as ready for review May 13, 2024 22:55
@ivokub ivokub requested a review from gbotrel May 13, 2024 22:55
@ivokub ivokub merged commit 5c74bd7 into master May 14, 2024
7 checks passed
@ivokub ivokub deleted the fix/nonnative-varmod branch May 14, 2024 04:42
@ivokub ivokub added the fuzzing Issue found using a fuzzing tool label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fuzzing Issue found using a fuzzing tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants