Perf: emulated BN254 pairing #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend options were split into prover and solver options. Usually when running the prover we set the solver options using backend.WithSolverOptions. But in tests makes sense that if we set `test.WithSolverOptions` then these options are also applied to the solver when run by the prover.
There are a lot of hints in the package. The preferred way of accessing all the hints is using GetHints()
ivokub
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Looks perfect! I only made some modifications to keep the interfaces similar, and didn't change anything in the computation itself.
Before merging I would just rebase on top of develop just in case to see we're not reintroducing regressions. There have been several updates to field emulation. If you are OK with it then I can do it myself and force push.
However, when I run TestPairTestSolve locally in test engine then 10% cases fail. I'll have a look to understand if it is due to field emulation. I would postpone merging until then.
ivokub
approved these changes
Mar 17, 2023
ivokub
reviewed
Mar 17, 2023
|
Some R1CS stats: |
This was referenced Mar 20, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking into account the new range check gadget, this PR removes almost 1M R1CS constraints from the emulated BN254 pairing (verified in a BN254 SNARK). It mostly follows "Pairings in R1CS" paper.