Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homestead and constantinople flags #9

Conversation

SatpalSandhu61
Copy link

@SatpalSandhu61 SatpalSandhu61 commented Aug 1, 2019

Added the Constantinople flag, which required additional changes to build with quorum v2.2.4.
Also restored the homestead flag that was incorrectly removed previously when byzantium was enabled.
Also added TransactionSizeLimit & IsQuorum.

…hen byzantium was enabled.

Impact of having it disabled is that a number of homestead features are not enabled; for example, if child contract creation runs out of gas then contract address is returned instead of error “contract creation code storage out of gas”.
Also restored the homestead flag that was incorrectly removed previously when byzantium was enabled.
@fixanoid fixanoid requested a review from trung August 1, 2019 15:48
@fixanoid fixanoid merged commit e679981 into Consensys:master Aug 2, 2019
@SatpalSandhu61 SatpalSandhu61 deleted the add-homestead-and-constantinople-flags branch August 2, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants