Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover: stitching compiler #39

Merged
merged 12 commits into from
Sep 23, 2024
Merged

Prover: stitching compiler #39

merged 12 commits into from
Sep 23, 2024

Conversation

Soleimani193
Copy link
Contributor

This PR refactorizes the stitching compiler. Particularly, some of the cases were skipped which could cause soundness problems. The new implementation addresses all the possible cases (including the column status or expression structure) the stitching compiler may encounter.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@Soleimani193 Soleimani193 added the Prover Tag to use for all work impacting the prover label Sep 16, 2024
@Soleimani193 Soleimani193 self-assigned this Sep 16, 2024
@Soleimani193 Soleimani193 changed the title Prover/stitching compiler Prover: stitching compiler Sep 16, 2024
@Soleimani193 Soleimani193 marked this pull request as ready for review September 16, 2024 10:46
Copy link

github-actions bot commented Sep 16, 2024

Delta Summary - Kotlin Code Coverage

Generated on: 09/23/2024 - 07:39
Description Previous Current Delta
Coverage date: 09/23/2024 - 07:39 09/23/2024 - 07:39
Tag: 312_10989641802 312_10989641802
Line coverage: 27.3% 27.3% 0.0%
Covered lines: 25578 25578 0
Coverable lines: 93680 93680 0
Total lines: 132748 132748 0
Branch coverage: 10.3% 10.3% 0.0%
Covered branches: 5494 5494 0
Total branches: 52848 52848 0
Method coverage: Feature is only available for sponsors

@Soleimani193 Soleimani193 force-pushed the prover/stitching-compiler branch 2 times, most recently from 5ba6def to 80d4dad Compare September 18, 2024 08:52
Copy link
Contributor

@arijitdutta67 arijitdutta67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Soleimani193 Soleimani193 merged commit d0a2536 into main Sep 23, 2024
21 checks passed
@Soleimani193 Soleimani193 deleted the prover/stitching-compiler branch September 23, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants