-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prover: stitching compiler #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soleimani193
force-pushed
the
prover/stitching-compiler
branch
from
September 16, 2024 10:45
2372cb2
to
ce1bd81
Compare
Delta Summary - Kotlin Code Coverage
|
Soleimani193
force-pushed
the
prover/stitching-compiler
branch
2 times, most recently
from
September 18, 2024 08:52
5ba6def
to
80d4dad
Compare
Soleimani193
force-pushed
the
prover/stitching-compiler
branch
from
September 19, 2024 10:11
fa74149
to
e61f853
Compare
AlexandreBelling
approved these changes
Sep 23, 2024
gusiri
approved these changes
Sep 23, 2024
arijitdutta67
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactorizes the stitching compiler. Particularly, some of the cases were skipped which could cause soundness problems. The new implementation addresses all the possible cases (including the column status or expression structure) the stitching compiler may encounter.
Checklist