Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3701): Apply Diligence Findings From Last Audit Round #63

Merged

Conversation

VGau
Copy link
Collaborator

@VGau VGau commented Sep 20, 2024

This PR implements issue(s) #3701

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@VGau VGau requested a review from a team as a code owner September 20, 2024 09:20
Copy link

github-actions bot commented Sep 24, 2024

Delta Summary - Kotlin Code Coverage

Generated on: 10/02/2024 - 17:04
Description Previous Current Delta
Coverage date: 10/02/2024 - 17:04 10/02/2024 - 17:04
Tag: 636_11148170645 636_11148170645
Line coverage: 27.3% 27.3% 0.0%
Covered lines: 25666 25666 0
Coverable lines: 93723 93723 0
Total lines: 132974 132974 0
Branch coverage: 10.4% 10.4% 0.0%
Covered branches: 5527 5527 0
Total branches: 52680 52680 0
Method coverage: Feature is only available for sponsors

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.82%. Comparing base (7a49044) to head (3a5d2bd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #63       +/-   ##
===========================================
+ Coverage        0   67.82%   +67.82%     
- Complexity      0     1039     +1039     
===========================================
  Files           0      248      +248     
  Lines           0    10389    +10389     
  Branches        0      867      +867     
===========================================
+ Hits            0     7046     +7046     
- Misses          0     2875     +2875     
- Partials        0      468      +468     
Flag Coverage Δ
kotlin 67.82% <ø> (?)

see 248 files with indirect coverage changes

@thedarkjester thedarkjester changed the base branch from main to feat/3907-state-reconstruction-events October 2, 2024 17:19
@thedarkjester thedarkjester merged commit 3a5d2bd into feat/3907-state-reconstruction-events Oct 3, 2024
14 of 19 checks passed
@thedarkjester thedarkjester deleted the feat/3701-diligence branch October 3, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants