1049 fix daily blockchain workflow #1152
Conversation
…ow' into 1049-fix-daily-blockchain-workflow # Conflicts: # reference-tests/build.gradle
reference-tests/build.gradle
Outdated
| @@ -52,6 +58,11 @@ tasks.register('referenceBlockchainTests', Test) { | |||
| description = 'Runs ETH reference blockchain tests.' | |||
| dependsOn generateBlockchainReferenceTests | |||
|
|
|||
| boolean isCiServer = System.getenv().containsKey("CI") | |||
| minHeapSize = isCiServer ? "8g" :"4g" | |||
| maxHeapSize = isCiServer ? "120g" : "8g" | |||
There was a problem hiding this comment.
I'm not sure if this will work, there is 128GB ram on the runner and if you reserve 120G for jvm, there isn't any left for corset.
…st.java.template, reduce maxHeapSize
| @@ -110,7 +110,7 @@ tasks.withType(Test).configureEach { | |||
| showSkippedStandardStreams false | |||
|
|
|||
| // set to false to hide failed standard out and error streams | |||
| showFailedStandardStreams true | |||
| showFailedStandardStreams false | |||
There was a problem hiding this comment.
Why do you want to set this to false?
There was a problem hiding this comment.
This was when I kept having the CI pipeline being cancelled without explanation so in an attempt to save memory I was removing the logs in the meantime.
reference-tests/build.gradle
Outdated
| boolean isCiServer = System.getenv().containsKey("CI") | ||
| minHeapSize = isCiServer ? "8g" :"4g" | ||
| maxHeapSize = isCiServer ? "20g" : "8g" | ||
| jvmArgs '-Xmx512m', '-Xms128m' |
There was a problem hiding this comment.
Wait, Xms and Xmx are used to set min and max heap size which are already set using minHeapSize and maxHeapSize. I am not sure which one will take effect.
There was a problem hiding this comment.
I've removed the xmx and xms args.
| private static ch.qos.logback.classic.Logger getLogbackLogger() { | ||
| try { | ||
| org.slf4j.Logger slf4jLogger = null; | ||
| for (int i = 0; i < LOGBACK_POLL_ATTEMPTS; i++) { |
There was a problem hiding this comment.
Why are these attempts needed? Is there way to alter the instantiating order of this Test watcher and the root logger so that the root logger will be available before the test watcher is instantiated.
There was a problem hiding this comment.
This was added because there were occasions when substituteLogger was being retrieved. Since adding this I have excluded some jars from conflicting dependencies so I'll test whether this is still required.
There was a problem hiding this comment.
It looks like it is still required.
|
|
||
| public static Stream<Arguments> getTestParametersForConfig() { | ||
| public static Stream<Arguments> getTestParametersForConfig() | ||
| throws ExecutionException, InterruptedException { |
There was a problem hiding this comment.
Doew generateTestParametersForConfig throw these exceptions?
There was a problem hiding this comment.
This was due to calling get() on a completable future, I've reworked the usage and this is no longer required.
No description provided.